Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
@conda-forge-admin, rerender |
…nda-forge-pinning 2020.03.20
|
Even if this works, I think we should consider completely removing that patch. |
|
I'm fine removing this patch entirely. It was in conda-forge before I started working on the python recipe so I kept it. |
|
What about using the anaconda branding mechanism instead? We change the c code. I can template the patch and apply the correct replacement at build time if that's acceptable? Branding is kinda useful if you change things significantly and I think, for better or worse we do that. But I don't mind if we remove it entirely for conda-forge either really. |
|
Having some kind of branding is useful I think. Though I don't know if we are discussing removing it or just some minor tweaks at this point. |
I don't know where to find that recipe? |
This PR does a minor tweak but I was suggesting we should consider removing it completely. |
|
For your information, I opened #332 completely removing the patching of |
|
Any interest in getting this in? |
|
Can you bump the build number? |
Done |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
@isuruf I bumped the build number - and did some more testing locally. |
|
The rerender seems to be problematic. I don't see why there should be a |
|
One build in linux-64 passing is enough |
Fixes #194
I would really advocate from completely removing the
brand_python.pythough. I don't think that modifying_sys_versionis a clean way of changing the banner.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)